Re: [PATCH v2 2/3] intel_pstate: add __init/__initdata marker to some functions/variables

[Srinivas Pandruvada]

On Mon, 2016-06-27 at 18:07 +0800, Jisheng Zhang wrote:
> These functions/variables are not needed after booting, so mark them
> as __init or __initdata.
> 
> Signed-off-by: Jisheng Zhang <jszhang@xxxxxxxxxxx>
> Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> ---
> Âdrivers/cpufreq/intel_pstate.c | 18 +++++++++---------
> Â1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/cpufreq/intel_pstate.c
> b/drivers/cpufreq/intel_pstate.c
> index 44099e9..861bcba 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -1355,7 +1355,7 @@ static const struct x86_cpu_id
> intel_pstate_cpu_ids[] = {
> Â};
> ÂMODULE_DEVICE_TABLE(x86cpu, intel_pstate_cpu_ids);
> Â
> -static const struct x86_cpu_id intel_pstate_cpu_oob_ids[] = {
> +static const struct x86_cpu_id intel_pstate_cpu_oob_ids[]
> __initconst = {
> Â	ICPU(0x56, core_params),
> Â	{}
> Â};
> @@ -1577,9 +1577,9 @@ static struct cpufreq_driver
> intel_pstate_driver = {
> Âstatic int no_load __initdata;
> Âstatic int no_hwp __initdata;
> Âstatic int hwp_only __initdata;
> -static unsigned int force_load;
> +static unsigned int force_load __initdata;
> Â
> -static int intel_pstate_msrs_not_valid(void)
> +static int __init intel_pstate_msrs_not_valid(void)
> Â{
> Â	if (!pstate_funcs.get_max() ||
> Â	ÂÂÂÂ!pstate_funcs.get_min() ||
> @@ -1589,7 +1589,7 @@ static int intel_pstate_msrs_not_valid(void)
> Â	return 0;
> Â}
> Â
> -static void copy_pid_params(struct pstate_adjust_policy *policy)
> +static void __init copy_pid_params(struct pstate_adjust_policy
> *policy)
> Â{
> Â	pid_params.sample_rate_ms = policy->sample_rate_ms;
> Â	pid_params.sample_rate_ns = pid_params.sample_rate_ms *
> NSEC_PER_MSEC;
> @@ -1600,7 +1600,7 @@ static void copy_pid_params(struct
> pstate_adjust_policy *policy)
> Â	pid_params.setpoint = policy->setpoint;
> Â}
> Â
> -static void copy_cpu_funcs(struct pstate_funcs *funcs)
> +static void __init copy_cpu_funcs(struct pstate_funcs *funcs)
> Â{
> Â	pstate_funcs.get_maxÂÂÂ= funcs->get_max;
> Â	pstate_funcs.get_max_physical = funcs->get_max_physical;
> @@ -1615,7 +1615,7 @@ static void copy_cpu_funcs(struct pstate_funcs
> *funcs)
> Â
> Â#ifdef CONFIG_ACPI
> Â
> -static bool intel_pstate_no_acpi_pss(void)
> +static bool __init intel_pstate_no_acpi_pss(void)
> Â{
> Â	int i;
> Â
> @@ -1644,7 +1644,7 @@ static bool intel_pstate_no_acpi_pss(void)
> Â	return true;
> Â}
> Â
> -static bool intel_pstate_has_acpi_ppc(void)
> +static bool __init intel_pstate_has_acpi_ppc(void)
> Â{
> Â	int i;
> Â
> @@ -1672,7 +1672,7 @@ struct hw_vendor_info {
> Â};
> Â
> Â/* Hardware vendor-specific info that has its own power management
> modes */
> -static struct hw_vendor_info vendor_info[] = {
> +static struct hw_vendor_info vendor_info[] __initdata = {
> Â	{1, "HPÂÂÂÂ", "ProLiant", PSS},
> Â	{1, "ORACLE", "X4-2ÂÂÂÂ", PPC},
> Â	{1, "ORACLE", "X4-2LÂÂÂ", PPC},
> @@ -1691,7 +1691,7 @@ static struct hw_vendor_info vendor_info[] = {
> Â	{0, "", ""},
> Â};
> Â
> -static bool intel_pstate_platform_pwr_mgmt_exists(void)
> +static bool __init intel_pstate_platform_pwr_mgmt_exists(void)
> Â{
> Â	struct acpi_table_header hdr;
> Â	struct hw_vendor_info *v_info;