Re: [PATCH] selftests/vm: Don't mlockall MCL_CURRENT in on-fault-limit test

From: Shuah Khan
Date: Mon Jun 27 2016 - 13:55:08 EST


On 06/20/2016 03:27 PM, Yannick Brosseau wrote:
> The default MEMLOCK limit is not big enough to accomodate all the
> current pages of the test program process, so the test fails
> at this step.
> By removing the MCL_CURRENT flag, we allow the mlockall
> call to succeed. The mmap is twice the size of the current limit,
> so it will still fail as expected.
>
> Signed-off-by: Yannick Brosseau <scientist@xxxxxx>

Thanks for the patch. I will get this into 4.8-rc1.

-- Shuah

> ---
> tools/testing/selftests/vm/on-fault-limit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/vm/on-fault-limit.c b/tools/testing/selftests/vm/on-fault-limit.c
> index 245accc..0ae458f 100644
> --- a/tools/testing/selftests/vm/on-fault-limit.c
> +++ b/tools/testing/selftests/vm/on-fault-limit.c
> @@ -20,7 +20,7 @@ static int test_limit(void)
> return ret;
> }
>
> - if (mlockall(MCL_CURRENT | MCL_ONFAULT | MCL_FUTURE)) {
> + if (mlockall(MCL_ONFAULT | MCL_FUTURE)) {
> perror("mlockall");
> return ret;
> }
>