Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

From: Linus Torvalds
Date: Mon Jun 27 2016 - 16:36:46 EST


On Mon, Jun 27, 2016 at 1:27 PM, Sedat Dilek <sedat.dilek@xxxxxxxxx> wrote:
>
> I just grepped for some "buzzwords" people gave me in this
> email-thread and I was looking at (llvm.git HEAD - upcoming v3.9
> release) and found these comments in [1]
>
>
> [1] https://github.com/llvm-mirror/llvm/blob/master/lib/Target/X86/X86InstrInfo.cpp#L4516

Christ. That's still pretty bad. Using LAHF/SAHF is just wrong.

But at least it's not semantically buggy any more, it's just stupid and slow.

Apparently the problem is that LLVM doesn't actually track flags as
different conditions, but as a single register, and doesn't know which
bits of it matter.

I guess the SETO + LAHF/SAHF is the best llvm can do then. But it
doesn't speak well of the code generation quality.

Linus