Re: [PATCH V1] mfd: da9053: fix compiler warning message for uninitialised variable
From: Lee Jones
Date: Tue Jun 28 2016 - 03:02:25 EST
On Mon, 27 Jun 2016, Steve Twiss wrote:
> From: Steve Twiss <stwiss.opensource@xxxxxxxxxxx>
>
> Fix compiler warning caused by an uninitialised variable inside
> da9052_group_write() function. Defaulting the value to zero covers
> the trivial case.
>
> Signed-off-by: Steve Twiss <stwiss.opensource@xxxxxxxxxxx>
> Reported-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
>
> ---
> Hi Lee,
>
> This compiler warning was found and reported by Geert Uytterhoeven as
> part of the "Build regressions/improvements in v4.7-rc5" thread.
>
> - https://lkml.org/lkml/2016/6/27/126
>
> Regards,
> Steve
>
>
> include/linux/mfd/da9052/da9052.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to -fixes.
> diff --git a/include/linux/mfd/da9052/da9052.h b/include/linux/mfd/da9052/da9052.h
> index c18a4c1..ce9230a 100644
> --- a/include/linux/mfd/da9052/da9052.h
> +++ b/include/linux/mfd/da9052/da9052.h
> @@ -171,7 +171,7 @@ static inline int da9052_group_read(struct da9052 *da9052, unsigned char reg,
> static inline int da9052_group_write(struct da9052 *da9052, unsigned char reg,
> unsigned reg_cnt, unsigned char *val)
> {
> - int ret;
> + int ret = 0;
> int i;
>
> for (i = 0; i < reg_cnt; i++) {
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog