Re: [PATCH V5 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga

[Tien Hock Loh]

My fault, I wasn't testing against building as module, was always
building as part of the kernel. I'll get it fixed and put another patch
for review.

Thanks
Tien Hock

On Tue, 2016-06-28 at 05:48 -0400, David Miller wrote:
> From: David Miller <davem@xxxxxxxxxxxxx>
> Date: Tue, 28 Jun 2016 05:34:50 -0400 (EDT)
> 
> > From: <thloh@xxxxxxxxxx>
> > Date: Fri, 24 Jun 2016 02:13:23 -0700
> > 
> >> From: Tien Hock Loh <thloh@xxxxxxxxxx>
> >> 
> >> This adds support for TSE PCS that uses SGMII adapter when the phy-mode of
> >> the dwmac is set to sgmii.
> >> 
> >> Signed-off-by: Tien Hock Loh <thloh@xxxxxxxxxx>
> >> Acked-by: Giuseppe Cavallaro <peppe.cavallaro@xxxxxx>
> >> Acked-by: Rob Herring <robh@xxxxxxxxxx>
> > 
> > Applied to net-next, thanks.
> 
> I had to revert, this breaks the build:
> 
> ERROR: "tse_pcs_fix_mac_speed" [drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.ko] undefined!
> ERROR: "tse_pcs_init" [drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.ko] undefined!