Re: [PATCH v9 06/12] kthread: Add kthread_drain_worker()

From: Tejun Heo
Date: Tue Jun 28 2016 - 13:05:42 EST


Hello,

On Mon, Jun 27, 2016 at 04:33:50PM +0200, Petr Mladek wrote:
> OK, so you suggest to do the following:
>
> 1. Add a flag into struct kthread_worker that will prevent
> from further queuing.

This doesn't add any protection, right? It's getting freed anyway.

> 2. kthread_create_worker()/kthread_destroy_worker() will
> not longer dynamically allocate struct kthread_worker.
> They will just start/stop the kthread.

Ah, okay, I don't think we need to change this. I was suggesting to
simplify it by dropping the draining and just do flush from destroy.

Thanks.

--
tejun