Re: [PATCH] mac80211: rx: frames received out of order
From: Johannes Berg
Date: Wed Jun 29 2016 - 03:19:38 EST
On Tue, 2016-06-28 at 14:15 +0300, Yaniv Machani wrote:
> From: Meirav Kama <meiravk@xxxxxx>
>
> MP received data frames from another MP. Frames are forwarded
> from Rx to Tx to be transmitted to a third MP.
> Upon cloning the skb, the tx_info was zeroed, and the
> hw_queue wasn't set correctly, causing frames to be
> inserted to queue 0 (VOICE). If re-queue occurred for some
> reason, frame will be inserted to correct queue 2 (BE).
> In this case frames are now dequeued from 2 different queues and
> sent out of order.
Please rewrite this commit log in active voice, and explain the fix
too.
> Signed-off-by: Meirav Kama <meiravk@xxxxxx>
> Acked-by: Yaniv Machani <yanivma@xxxxxx>
See Julian's comment.
johannes