Re: [PATCH] power: qcom-smbb: add extcon dependency

From: Stephen Boyd
Date: Wed Jun 29 2016 - 14:10:42 EST


On 06/29/2016 07:38 AM, Sebastian Reichel wrote:
> Hi,
>
> On Wed, Jun 29, 2016 at 04:30:02PM +0200, Arnd Bergmann wrote:
>> Building the smbb driver without extcon results in a link failure:
>>
>> drivers/power/built-in.o: In function `smbb_usb_valid_handler':
>> :(.text+0x3190): undefined reference to `extcon_set_cable_state_'
>> drivers/power/built-in.o: In function `smbb_charger_probe':
>> :(.text+0x3880): undefined reference to `devm_extcon_dev_allocate'
>> :(.text+0x3898): undefined reference to `devm_extcon_dev_register'
>>
>> This adds a Kconfig dependency.
>>
>> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>> Fixes: 56d7df8716b2 ("power: Add Qualcomm SMBB driver")

extcon use was only recently introduced so this should be

Fixes: 0b7fe26ae602 ("power: qcom_smbb: Make an extcon for usb cable
detection")

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project