RE: [PATCH] mwifiex: Fixed endianness for event TLV type TLV_BTCOEX_WL_SCANTIME

[Amitkumar Karwar]

Hi Prasun,

> From: Prasun Maiti [mailto:prasunmaiti87@xxxxxxxxx]
> Sent: Friday, June 24, 2016 12:27 PM
> To: Amitkumar Karwar; Nishant Sarmukadam; Kalle Valo
> Cc: Linux Wireless; Linux Next; Linux Kernel
> Subject: Re: [PATCH] mwifiex: Fixed endianness for event TLV type
> TLV_BTCOEX_WL_SCANTIME
> 
> On Thu, Jun 16, 2016 at 9:49 AM, Prasun Maiti <prasunmaiti87@xxxxxxxxx>
> wrote:
> > The two members min_scan_time and max_scan_time of structure
> > "mwifiex_ie_types_btcoex_scan_time" are of two bytes each. The values
> > are assigned directtly from firmware without endian conversion
> handling.
> > So, wrong datas will get saved in big-endian systems.
> >
> > This patch converts the values into cpu's byte order before assigning
> > them into the local members.
> >
> > Signed-off-by: Prasun Maiti <prasunmaiti87@xxxxxxxxx>
> > ---
> >  drivers/net/wireless/marvell/mwifiex/sta_event.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/wireless/marvell/mwifiex/sta_event.c
> > b/drivers/net/wireless/marvell/mwifiex/sta_event.c
> > index 0104108..7dff452 100644
> > --- a/drivers/net/wireless/marvell/mwifiex/sta_event.c
> > +++ b/drivers/net/wireless/marvell/mwifiex/sta_event.c
> > @@ -474,8 +474,8 @@ void
> mwifiex_bt_coex_wlan_param_update_event(struct mwifiex_private *priv,
> >                         scantlv =
> >                             (struct mwifiex_ie_types_btcoex_scan_time
> *)tlv;
> >                         adapter->coex_scan = scantlv->coex_scan;
> > -                       adapter->coex_min_scan_time = scantlv-
> >min_scan_time;
> > -                       adapter->coex_max_scan_time = scantlv-
> >max_scan_time;
> > +                       adapter->coex_min_scan_time =
> le16_to_cpu(scantlv->min_scan_time);
> > +                       adapter->coex_max_scan_time =
> > + le16_to_cpu(scantlv->max_scan_time);
> >                         break;
> >
> >                 default:
> > --
> > 1.9.1
> >

Along with this change, you need to define these elements as __le16 in scan_tlv structure. Ensure that sparse compilation is passed with your final patch.

Regards,
Amitkumar