Re: [PATCH] ARM: shmobile: don't call platform_can_secondary_boot on UP

[Geert Uytterhoeven]

Hi Arnd,

On Thu, Jun 30, 2016 at 2:25 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> For rcar-gen2, we build the SMP files even for UP configurations,
> and that just broke:
>
> arch/arm/mach-shmobile/built-in.o: In function `shmobile_smp_init_fallback_ops':
> pm-rcar-gen2.c:(.init.text+0x40c): undefined reference to `platform_can_secondary_boot'
>
> This adds an compile-time check before the call to platform_can_secondary_boot,
> turning the function into an empty stub for UP configurations.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Fixes: c21af444eace ("ARM: shmobile: smp: Add function to prioritize DT SMP")

Crap, I think I took the shortcut of only compile-testing
arch/arm/mach-shmobile,
not link-testing the whole kernel, with CONFIG_SMP=n...

Acked-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds