Re: [PATCH 1/5] perf test: Add -F/--dont-fork option
From: Nilay Vaish
Date: Thu Jun 30 2016 - 09:27:30 EST
On 29 June 2016 at 11:07, Arnaldo Carvalho de Melo
<arnaldo.melo@xxxxxxxxx> wrote:
> Em Wed, Jun 29, 2016 at 11:04:01AM -0500, Nilay Vaish escreveu:
>> On 28 June 2016 at 06:29, Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
>> > Adding -F/--dont-fork option to bypass forking
>> > for each test. It's useful for debugging test.
>> >
>> > Link: http://lkml.kernel.org/n/tip-yq9gy0fcr8nl70986gwnl3dh@xxxxxxxxxxxxxx
>> > Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
>> > ---
>> > tools/perf/Documentation/perf-test.txt | 4 +++
>> > tools/perf/tests/builtin-test.c | 55 ++++++++++++++++++++--------------
>> > 2 files changed, 37 insertions(+), 22 deletions(-)
>> >
>>
>> This patch seems fine to me.
>
> In these cases, please state that more formally, i.e. please read
> Documentation/SubmittingPatches, specially this section:
>
> 12) When to use Acked-by:
>
> and:
>
> 13) Using Reported-by:, Tested-by:, Reviewed-by:, Suggested-by: and
> Fixes:
>
Thanks for the info.
--
Nilay