RE: [PATCH 3/6] ACPICA: make use of new strtolower() function

[Moore, Robert]

Where is "strtolower" implemented?


> -----Original Message-----
> From: Markus Mayer [mailto:mmayer@xxxxxxxxxxxx]
> Sent: Thursday, June 30, 2016 4:50 PM
> To: Moore, Robert; Zheng, Lv; Wysocki, Rafael J; Len Brown
> Cc: Markus Mayer; linux-acpi@xxxxxxxxxxxxxxx; devel@xxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH 3/6] ACPICA: make use of new strtolower() function
> 
> Call strtolower() rather than walking the string explicitly to convert it
> to lowercase.
> 
> Signed-off-by: Markus Mayer <mmayer@xxxxxxxxxxxx>
> ---
> 
> *** Please note that there don't seem to be any callers of
> acpi_ut_strlwr().
> *** It may be possible to remove the function altogether.
> 
>  drivers/acpi/acpica/utnonansi.c | 13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)
> 
> diff --git a/drivers/acpi/acpica/utnonansi.c
> b/drivers/acpi/acpica/utnonansi.c index 3465fe2..b6e11dc 100644
> --- a/drivers/acpi/acpica/utnonansi.c
> +++ b/drivers/acpi/acpica/utnonansi.c
> @@ -64,19 +64,8 @@ ACPI_MODULE_NAME("utnonansi")
> 
> **************************************************************************
> ****/
>  void acpi_ut_strlwr(char *src_string)
>  {
> -	char *string;
> -
>  	ACPI_FUNCTION_ENTRY();
> -
> -	if (!src_string) {
> -		return;
> -	}
> -
> -	/* Walk entire string, lowercasing the letters */
> -
> -	for (string = src_string; *string; string++) {
> -		*string = (char)tolower((int)*string);
> -	}
> +	strtolower(src_string);
>  }
> 
> 
> /*************************************************************************
> ******
> --
> 2.7.4