Re: [PATCH v4 14/22] sh: SH7751 core dtsi

[Geert Uytterhoeven]

Hi Sato-san,

On Wed, Jun 29, 2016 at 3:40 PM, Yoshinori Sato
<ysato@xxxxxxxxxxxxxxxxxxxx> wrote:
> SH7751 core and internal peripheral define.

Thanks for your patch!

> Changes v4
> - remove unneeded #address-cells and #size-cells
> - add missing dt-binding link

Please move changelog information below the three dashes...

>
> Signed-off-by: Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx>
> ---

... i.e. here.

> --- /dev/null
> +++ b/arch/sh/boot/dts/include/dt-bindings
> @@ -0,0 +1 @@
> +../../../../../include/dt-bindings
> \ No newline at end of file

Missing newline.

> --- /dev/null
> +++ b/arch/sh/boot/dts/sh7751.dtsi

> +       oclk: oscillator {
> +                #clock-cells = <0>;
> +                compatible = "fixed-clock";
> +                clock-frequency = <0>;
> +        };
> +       cpg: cpg@ffc00000 {

clock-controller@ffc00000

> \ No newline at end of file

Missing newline.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds