Re: [PATCH -v2 1/2] ratelimit: Extend to print suppressed messages on release

[Ingo Molnar]

* Borislav Petkov <bp@xxxxxxxxx> wrote:

> On Fri, Jul 01, 2016 at 12:17:43PM +0200, Ingo Molnar wrote:
> > Yeah, indeed, you are right.
> 
> How about this though, still:
> 
> ratelimit_state_exit:
> 
>         if (rs->missed)
>                 printk(KERN_WARNING "%s: %d output lines suppressed due to ratelimiting\n",
>                        current->comm, rs->missed);
> 
> 
> I still think it is better than the "callbacks" thing as we're issuing
> it on release and there's not really a @func which callbacks we're
> limiting...

Yeah, indeed!

Thanks,

	Ingo