Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer
From: Daniel Lezcano
Date: Fri Jul 01 2016 - 10:00:44 EST
On 06/30/2016 03:27 PM, Rafael J. Wysocki wrote:
[ ... ]
GTDT is part of ACPI spec, drivers/acpi/ is for driver code of
ACPI spec, I think it can stay in drivers/acpi/ from this point
of view, am I right?
The question is not "Can it?", but "Does it need to?".
It is in the spec, but still there's only one architecture needing it.
There is no way to test it on any other architecture and no reason to build it
for any other architecture, so why does it need to be located in drivers/acpi/ ?
Hi Rafael,
what is the problem of having it in drivers/acpi ?
There are cpufreq-dt, speedstep*, tegra124-* in drivers/cpufreq.
clocksource-probe which is DT based with different drivers using it in
drivers/clocksource with a pletore of different archs.
Cstate code which is only used by x86 is in drivers/acpi, it is only
used by x86/ia64 and it isn't a problem. There is a small chunk in
arch/x86/kernel/acpi and it doesn't facilitate the comprehension of the
code.
IMHO, having all ACPI code in the same directory will encourage the
consolidation.
--
<http://www.linaro.org/> Linaro.org â Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog