Re: [PATCH v12 1/8] perf tests: Skip backward ring buffer on old kernel

From: Arnaldo Carvalho de Melo
Date: Fri Jul 01 2016 - 10:43:10 EST


Em Fri, Jul 01, 2016 at 10:27:35PM +0800, pi3orama escreveu:
> > å 2016å7æ1æïäå9:40ïArnaldo Carvalho de Melo <acme@xxxxxxxxxx> åéï
> > I.e. perhaps evsel->overwrite is completely unnecessary and places
> > checking for it should instead check for evsel->attr.backward, no?

> If we remove evsel->overwrite, what should we set in parser? Make it
> directly setting attr?

yeah, is that possible? Trying... And then overwrite is how we chose to
expose this to the user, in the event syntax, but internally that means
using the backwards_ring buffer, right?

So this simplifies the code, removing information that was being
duplicated in evsel->overwrite and evsel->attr.write_backward.

- Arnaldo