Re: [PATCH] mwifiex: mask PCIe interrupts before removal
From: Doug Anderson
Date: Fri Jul 01 2016 - 13:42:46 EST
Hi,
On Thu, Jun 30, 2016 at 3:21 PM, Brian Norris <briannorris@xxxxxxxxxxxx> wrote:
> The PCIe driver didn't mask the host interrupts before trying to tear
> down. This causes lockups at reboot or rmmod when using MSI-X on 8997,
> since the MSI handler gets confused and locks up the system.
>
> Also tested on 8897, which does not support MSI-X (and wasn't
> experiencing this same bug). No regressions seen there.
>
> Signed-off-by: Brian Norris <briannorris@xxxxxxxxxxxx>
> ---
> drivers/net/wireless/marvell/mwifiex/pcie.c | 6 ++++++
> 1 file changed, 6 insertions(+)
This looks very sane but isn't my area of expertise at all. However,
if my Reviewed-by is at all useful feel free to add it. I will say
that this fixes the issue of the crash at reboot time, so at least
I'll add:
Tested-by: Douglas Anderson <dianders@xxxxxxxxxxxx>