Re: [PATCH 03/12] PM,devfreq: Employ atomic_fetch_inc()

[Chanwoo Choi]

Hi Davidlohr,


Acked-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>

Thanks,
Chanwoo Choi


2016-06-21 5:05 GMT+09:00 Davidlohr Bueso <dave@xxxxxxxxxxxx>:
> Now that we have fetch_inc() we can stop using inc_return() - 1.
>
> These are very similar to the existing OP-RETURN primitives we already
> have, except they return the value of the atomic variable _before_
> modification.
>
> Cc: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> Cc: linux-pm@xxxxxxxxxxxxxxx
> Signed-off-by: Davidlohr Bueso <dbueso@xxxxxxx>
> ---
>  drivers/devfreq/devfreq-event.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/devfreq/devfreq-event.c b/drivers/devfreq/devfreq-event.c
> index 39b048eda2ce..45b02d3d7e7d 100644
> --- a/drivers/devfreq/devfreq-event.c
> +++ b/drivers/devfreq/devfreq-event.c
> @@ -329,7 +329,7 @@ struct devfreq_event_dev *devfreq_event_add_edev(struct device *dev,
>         edev->dev.class = devfreq_event_class;
>         edev->dev.release = devfreq_event_release_edev;
>
> -       dev_set_name(&edev->dev, "event.%d", atomic_inc_return(&event_no) - 1);
> +       dev_set_name(&edev->dev, "event.%d", atomic_fetch_inc(&event_no));
>         ret = device_register(&edev->dev);
>         if (ret < 0) {
>                 put_device(&edev->dev);
> --
> 2.6.6
>