Re: [PATCH v4 19/22] sh: IO-DATA HDL-U (a,k.a landisk) IRQCHIP driver
From: Yoshinori Sato
Date: Sun Jul 03 2016 - 07:36:42 EST
On Fri, 01 Jul 2016 10:48:53 +0900,
Rob Herring wrote:
>
> On Wed, Jun 29, 2016 at 10:41:04PM +0900, Yoshinori Sato wrote:
> > Changes v4
> > - split patches
> > - remove unneeded line
> > - example update
> >
> > Signed-off-by: Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx>
> > ---
> > .../interrupt-controller/iodata-landisk.txt | 31 ++++++++++
> > drivers/irqchip/Makefile | 2 +-
> > drivers/irqchip/irq-io-landisk.c | 72 ++++++++++++++++++++++
> > 3 files changed, 104 insertions(+), 1 deletion(-)
> > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/iodata-landisk.txt
> > create mode 100644 drivers/irqchip/irq-io-landisk.c
> >
> > diff --git a/Documentation/devicetree/bindings/interrupt-controller/iodata-landisk.txt b/Documentation/devicetree/bindings/interrupt-controller/iodata-landisk.txt
> > new file mode 100644
> > index 0000000..cf461dc
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/interrupt-controller/iodata-landisk.txt
> > @@ -0,0 +1,31 @@
> > +DT bindings for the I/O DATA HDL-U interrupt controller
> > +
> > +Required properties:
> > +
> > + - compatible: has to be "iodata,landisk-intc".
> > +
> > + - reg: Base address and length of interrupt controller register.
> > +
> > + - interrupt-controller: Identifies the node as an interrupt controller.
> > +
> > + - #interrupt-cells: has to be <1>: an interrupt index.
> > +
> > + - interrupt-map: Interrupt mapping on parent controller.
>
> interrupt-controller and interrupt-map are supposed to be mutually
> exclusive, so you should probably drop interrupt-controller.
Yes. This logic is not interrupt controller.
Remove this line.
> Rob
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Yoshinori Sato
<ysato@xxxxxxxxxxxxxxxxxxxx>