Re: [PATCH 6/8] mm/zsmalloc: keep comments consistent with code
From: Ganesh Mahendran
Date: Sun Jul 03 2016 - 23:32:34 EST
On Mon, Jul 04, 2016 at 09:05:16AM +0900, Minchan Kim wrote:
> On Fri, Jul 01, 2016 at 02:41:04PM +0800, Ganesh Mahendran wrote:
> > some minor change of comments:
> > 1). update zs_malloc(),zs_create_pool() function header
> > 2). update "Usage of struct page fields"
> >
> > Signed-off-by: Ganesh Mahendran <opensource.ganesh@xxxxxxxxx>
> > ---
> > mm/zsmalloc.c | 7 +++----
> > 1 file changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> > index 2690914..6fc631a 100644
> > --- a/mm/zsmalloc.c
> > +++ b/mm/zsmalloc.c
> > @@ -20,6 +20,7 @@
> > * page->freelist(index): links together all component pages of a zspage
> > * For the huge page, this is always 0, so we use this field
> > * to store handle.
> > + * page->units: first object index in a subpage of zspage
>
> Hmm, I want to use offset instead of index.
Yes, it should be offset here. I mixed it with obj index. :)
Thanks