Re: [PATCH 4/6] irqchip: add irqchip driver for nuc900
From: Arnd Bergmann
Date: Tue Jul 05 2016 - 04:07:29 EST
On Tuesday, July 5, 2016 3:47:25 PM CEST Wan Zongshun wrote:
> On 2016å06æ29æ 23:27, Arnd Bergmann wrote:
> > On Saturday, June 25, 2016 6:37:20 PM CEST Wan Zongshun wrote:
> >> +#define IRQ_WDT W90X900_IRQ(1)
> >> +#define IRQ_WWDT W90X900_IRQ(2)
> >> +#define IRQ_LVD W90X900_IRQ(3)
> >> +#define IRQ_EXT0 W90X900_IRQ(4)
> >> +#define IRQ_EXT1 W90X900_IRQ(5)
> >> +#define IRQ_EXT2 W90X900_IRQ(6)
> >> +#define IRQ_EXT3 W90X900_IRQ(7)
> >> +#define IRQ_EXT4 W90X900_IRQ(8)
> >> +#define IRQ_EXT5 W90X900_IRQ(9)
> >> +#define IRQ_EXT6 W90X900_IRQ(10)
> >
> > I'd suggest dropping the list, the contents are now in the dts.
>
> Do you think I should put one irqmap header file into this
> /arch/arm/boot/dts/include/dt-bindings folder, or I should removed those
> irqnumber map anywhere, just hardcode the irqnumber in dts file?
Just hardcode it.
Arnd