Re: [PATCH] tracing: Have HIST_TRIGGERS select TRACING

From: Steven Rostedt
Date: Tue Jul 05 2016 - 15:48:47 EST


On Sun, 03 Jul 2016 08:51:34 -0500
Tom Zanussi <tom.zanussi@xxxxxxxxxxxxxxx> wrote:

> The kbuild test robot reported a compile error if HIST_TRIGGERS was
> enabled but nothing else that selected TRACING was configured in.
>
> HIST_TRIGGERS should directly select it and not rely on anything else
> to do it.
>

I added:

Reported-by: kbuild test robot <fennguang.wu@xxxxxxxxx>
Fixes: 7ef224d1d0e3a ("tracing: Add 'hist' event trigger command")


This isn't that big of a deal, so I'm just going to put it into my
queue for the next merge window.

-- Steve


> Signed-off-by: Tom Zanussi <tom.zanussi@xxxxxxxxxxxxxxx>
> ---
> kernel/trace/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> index fafeaf8..f4b86e8 100644
> --- a/kernel/trace/Kconfig
> +++ b/kernel/trace/Kconfig
> @@ -542,6 +542,7 @@ config HIST_TRIGGERS
> bool "Histogram triggers"
> depends on ARCH_HAVE_NMI_SAFE_CMPXCHG
> select TRACING_MAP
> + select TRACING
> default n
> help
> Hist triggers allow one or more arbitrary trace event fields