Re: [PATCH 1/2] mfd: cros_ec: Add MKBP event support

From: Olof Johansson
Date: Tue Jul 05 2016 - 16:55:49 EST


On Tue, Jul 5, 2016 at 1:54 PM, Olof Johansson <olof@xxxxxxxxx> wrote:
> On Fri, Jul 1, 2016 at 2:07 AM, Enric Balletbo i Serra
> <enric.balletbo@xxxxxxxxxxxxx> wrote:
>> From: Vic Yang <victoryang@xxxxxxxxxx>
>>
>> Newer revisions of the ChromeOS EC add more events besides the keyboard
>> ones. So handle interrupts in the MFD driver and let consumers register
>> for notifications for the events they might care.
>>
>> To keep backward compatibility, if the EC doesn't support MKBP event, we
>> fall back to the old MKBP key matrix host command.
>>
>> Signed-off-by: Vic Yang <victoryang@xxxxxxxxxx>
>> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@xxxxxxxxxxxxx>
>> Tested-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>
>> Cc: Randall Spangler <rspangler@xxxxxxxxxxxx>
>> Cc: Vincent Palatin <vpalatin@xxxxxxxxxxxx>
>> Cc: Benson Leung <bleung@xxxxxxxxxxxx>
>
> Probably easiest to merge this through the MFD tree due to the
> overlaps, so for that purpose:
>
> Acked-by: Olof Johansson <olof@xxxxxxxxx>

Argh, I just noticed that the second patch is an input patch, not
another MFD patch. Either way, I'm OK with this going through the
input tree if that's easiest. If so, you should probably wait for an
ack from Lee as well.


-Olof