Re: [PATCH 2/2] net: ethernet: bcmgenet: use phy_ethtool_{get|set}_link_ksettings

[Philippe Reynes]

Hi Florian,

On 05/07/16 06:30, Florian Fainelli wrote:
> Le 04/07/2016 16:03, David Miller a écrit :
> > From: Philippe Reynes<tremyfr@xxxxxxxxx>
> > Date: Sun,  3 Jul 2016 17:33:57 +0200
> >
> > > There are two generics functions phy_ethtool_{get|set}_link_ksettings,
> > > so we can use them instead of defining the same code in the driver.
> > >
> > > Signed-off-by: Philippe Reynes<tremyfr@xxxxxxxxx>
> >
> > Applied.
>
> The transformation is not equivalent, we lost the checks on
> netif_running() in the process, and those are here for a reason, if the
> interface is down and therefore clock gated, MDIO accesses to the PHY
> will simply fail outright and cause bus errors.

Oh, I see, I've missed this. Sorry for this mistake.
We should revert this path.

I think that a lot of hardware had the same behaviour.
I'm going to look for a generic solution for this behaviour.
If someone has an idea ...
 
> Philippe, have you tested this?

I haven't tested, I don't have the hardware.


Philippe