Re: [PATCH 5/5] ACPI: Add configuration item to configure ACPICA error logs out

From: Rafael J. Wysocki
Date: Tue Jul 05 2016 - 19:43:12 EST


On Tue, Jul 5, 2016 at 1:18 PM, Lv Zheng <lv.zheng@xxxxxxxxx> wrote:
> Sometimes, we need to disable ACPICA error logs to leave only ACPICA
> debug logs enabled for debugging purpose. This is useful when ACPICA error
> logs become a flood.
>
> Reference: https://bugzilla.kernel.org/show_bug.cgi?id=114201
> Signed-off-by: Lv Zheng <lv.zheng@xxxxxxxxx>

I seem to remember seeing this change once before and ISTR I said I
wouldn't apply it then.

Why would I say something different this time?

> ---
> drivers/acpi/Kconfig | 7 +++++++
> include/acpi/platform/aclinux.h | 4 ++++
> 2 files changed, 11 insertions(+)
>
> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> index 04af18f..939d235 100644
> --- a/drivers/acpi/Kconfig
> +++ b/drivers/acpi/Kconfig
> @@ -324,6 +324,13 @@ config ACPI_TABLE_UPGRADE
> initrd, therefore it's safe to say Y.
> See Documentation/acpi/initrd_table_override.txt for details
>
> +config ACPI_NO_ERROR_MESSAGES
> + bool "Disable error messages"
> + default n
> + help
> + The ACPI subsystem can produce error messages. Saying Y disables
> + this output.
> +
> config ACPI_DEBUG
> bool "Debug Statements"
> default n
> diff --git a/include/acpi/platform/aclinux.h b/include/acpi/platform/aclinux.h
> index 93b61b1..ed27b52 100644
> --- a/include/acpi/platform/aclinux.h
> +++ b/include/acpi/platform/aclinux.h
> @@ -77,6 +77,10 @@
> #define ACPI_MUTEX_DEBUG
> #endif
>
> +#ifdef CONFIG_ACPI_NO_ERROR_MESSAGES
> +#define ACPI_NO_ERROR_MESSAGES
> +#endif
> +
> #include <linux/string.h>
> #include <linux/kernel.h>
> #include <linux/ctype.h>
> --