Re: [PATCH v3 6/8] mm/zsmalloc: add __init,__exit attribute

From: Ganesh Mahendran
Date: Wed Jul 06 2016 - 04:20:20 EST


On Wed, Jul 06, 2016 at 02:23:51PM +0800, Ganesh Mahendran wrote:
> Add __init,__exit attribute for function that only called in
> module init/exit to save memory.
>
> Signed-off-by: Ganesh Mahendran <opensource.ganesh@xxxxxxxxx>
> ----
> v3:
> revert change in v2 - Sergey
> v2:
> add __init/__exit for zs_register_cpu_notifier/zs_unregister_cpu_notifier
> ---
> mm/zsmalloc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> index ded312b..46526b9 100644
> --- a/mm/zsmalloc.c
> +++ b/mm/zsmalloc.c
> @@ -1344,7 +1344,7 @@ static void zs_unregister_cpu_notifier(void)
> cpu_notifier_register_done();
> }
>
> -static void init_zs_size_classes(void)
> +static void __init init_zs_size_classes(void)
> {
> int nr;
>
> @@ -1887,7 +1887,7 @@ static struct file_system_type zsmalloc_fs = {
> .kill_sb = kill_anon_super,
> };
>
> -static int zsmalloc_mount(void)
> +static int __init zsmalloc_mount(void)
> {
> int ret = 0;
>
> @@ -1898,7 +1898,7 @@ static int zsmalloc_mount(void)
> return ret;
> }
>
> -static void zsmalloc_unmount(void)
> +static void __exit zsmalloc_unmount(void)
> {
> kern_unmount(zsmalloc_mnt);
> }

Sorry, the __exit zsmalloc_umount is called in __init zs_init.

updated patch is :

---