Re: [PATCH] dmaengine: qcom-bam-dma: add __maybe_unused annotations for PM
From: Vinod Koul
Date: Wed Jul 06 2016 - 13:03:06 EST
On Mon, Jul 04, 2016 at 03:14:08PM +0200, Arnd Bergmann wrote:
> The bam_dma driver gained runtime PM support, but that causes build
> warnings whenever CONFIG_PM is disabled:
>
> drivers/dma/qcom/bam_dma.c:1324:12: error: 'bam_dma_runtime_resume' defined but not used [-Werror=unused-function]
> static int bam_dma_runtime_resume(struct device *dev)
> ^~~~~~~~~~~~~~~~~~~~~~
> drivers/dma/qcom/bam_dma.c:1315:12: error: 'bam_dma_runtime_suspend' defined but not used [-Werror=unused-function]
> static int bam_dma_runtime_suspend(struct device *dev)
>
> This removes the incomplete #ifdef guard and instead marks all
> four PM functions as __maybe_unused, which avoids this kind of
> warning.
Applied, thanks
--
~Vinod