Re: [PATCH 1/1][V2] usb: quirks: Add no-lpm quirk for Elan

[Joseph Salisbury]

On 07/06/2016 09:02 PM, Greg KH wrote:
> On Wed, Jul 06, 2016 at 08:58:14PM -0400, Joseph Salisbury wrote:
>> BugLink: http://bugs.launchpad.net/bugs/1498667
>>
>> As reported in BugLink, this device has an issue with Linux Power 
>> Management so adding a quirk.  This quirk was reccomended by Alan Stern:
>>
>> http://lkml.iu.edu/hypermail/linux/kernel/1606.2/05590.html
>>
>> Signed-off-by: Joseph Salisbury <joseph.salisbury@xxxxxxxxxxxxx>
>> Cc: stable <stable@xxxxxxxxxxxxxxx>
>> ---
>>  drivers/usb/core/quirks.c | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
>> index 944a6dc..f028cc5 100644
>> --- a/drivers/usb/core/quirks.c
>> +++ b/drivers/usb/core/quirks.c
>> @@ -127,10 +127,13 @@ static const struct usb_device_id usb_quirk_list[] = {
>>  
>>  	{ USB_DEVICE(0x04f3, 0x016f), .driver_info =
>>  			USB_QUIRK_DEVICE_QUALIFIER },
>> +
>> +	{ USB_DEVICE(0x04f3, 0x0381), .driver_info =
>> +			USB_QUIRK_NO_LPM },
>>  
>>  	{ USB_DEVICE(0x04f3, 0x21b8), .driver_info =
>>  			USB_QUIRK_DEVICE_QUALIFIER },
>> -
>> +
> This is odd, why remove and add a blank line for no reason?
>
That is odd and wasn't intentional, I'll send a V3.