Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct attribute_group"
From: Konrad Rzeszutek Wilk
Date: Thu Jul 07 2016 - 11:38:16 EST
On Thu, Jul 07, 2016 at 10:52:18AM +0100, Andrew Cooper wrote:
> On 07/07/16 10:45, Roger Pau Monne wrote:
> > On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote:
> >> The functions such get passed to have been taking pointers to const
> >> since at least 2.6.16.
> >>
> >> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> > Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> >
> > Although the wording in the commit message looks weird to me, but I'm not a
> > native speaker anyway.
>
> As a native speaker, I can't parse it either.
>
> I think s/such/these/ is needed.
The functions such as these have been taking pointers to const
since at least 2.6.16.
?
>
> ~Andrew
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> https://lists.xen.org/xen-devel