Re: [Xen-devel] [PATCH] xen/apic: Update the comment for apic_id_mask

[Boris Ostrovsky]

On 07/07/2016 11:25 AM, Konrad Rzeszutek Wilk wrote:
> On Thu, Jul 07, 2016 at 11:28:18AM +0800, Wei Jiangang wrote:
>> verify_local_APIC() had been removed by
>> commit 4399c03c6780 ("x86/apic: Remove verify_local_APIC()"),
>> so apic_id_mask isn't used by it.

Is anyone actually using this field? It looks like 4399c03c6780 removed
the only user.

-boris


> CC-ing the proper maintainers.
>> Signed-off-by: Wei Jiangang <weijg.fnst@xxxxxxxxxxxxxx>
>> ---
>>  arch/x86/xen/apic.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/xen/apic.c b/arch/x86/xen/apic.c
>> index db52a7fafcc2..9cbb1f48381b 100644
>> --- a/arch/x86/xen/apic.c
>> +++ b/arch/x86/xen/apic.c
>> @@ -177,7 +177,7 @@ static struct apic xen_pv_apic = {
>>  
>>  	.get_apic_id 			= xen_get_apic_id,
>>  	.set_apic_id 			= xen_set_apic_id, /* Can be NULL on 32-bit. */
>> -	.apic_id_mask			= 0xFF << 24, /* Used by verify_local_APIC. Match with what xen_get_apic_id does. */
>> +	.apic_id_mask			= 0xFF << 24, /* Match with what xen_get_apic_id does. */
>>  
>>  	.cpu_mask_to_apicid_and		= flat_cpu_mask_to_apicid_and,
>>  
>> -- 
>> 1.9.3
>>
>>
>>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@xxxxxxxxxxxxx
>> https://lists.xen.org/xen-devel