Re: [PATCH] regmap: add iopoll-like polling macro

From: Mark Brown
Date: Fri Jul 08 2016 - 10:40:10 EST


On Thu, Jul 07, 2016 at 12:01:43PM +0200, Philipp Zabel wrote:
> Am Donnerstag, den 07.07.2016, 11:42 +0200 schrieb Mark Brown:
> > On Wed, Jul 06, 2016 at 04:19:41PM +0200, Philipp Zabel wrote:

> > > This patch adds a macro regmap_read_poll_timeout that works similar
> > > to the readx_poll_timeout defined in linux/iopoll.h, except that this
> > > can also return the error value returned by a failed regmap_read.

> > Please make this a proper function.

> I can't, the condition has to be evaluated inside the loop. This is
> basically a poor man's function template.

Given that the condition is always going to be essentially the same one
checking that (read & mask) == value we could just parameterize it
couldn't we?

Attachment: signature.asc
Description: PGP signature