Re: [PATCH v14 4/8] perf record: Introduce rec->overwrite_evlist for overwritable events

[Jiri Olsa]

On Thu, Jul 07, 2016 at 05:34:45AM +0000, Wang Nan wrote:

SNIP

> +	if (err)
> +		return err;
> +
> +	err = record__mmap_evlist(rec, rec->evlist, false);
> +	if (err)
> +		return err;
> +
> +	if (!rec->overwrite_evlist)
> +		return 0;
> +
> +	err = record__mmap_evlist(rec, rec->overwrite_evlist, true);
> +	if (err)
> +		return err;
> +	return 0;
>  }
>  
>  static int record__open(struct record *rec)
> @@ -698,9 +743,14 @@ static const struct perf_event_mmap_page *record__pick_pc(struct record *rec)
>  {
>  	const struct perf_event_mmap_page *pc;
>  
> +	/* Change it to a loop if a new aux evlist is added */
>  	pc = perf_evlist__pick_pc(rec->evlist);
>  	if (pc)
>  		return pc;
> +	pc = perf_evlist__pick_pc(rec->overwrite_evlist);
> +	if (pc)
> +		return pc;
> +
>  	return NULL;

above 4 lines could be just:

	return perf_evlist__pick_pc(rec->overwrite_evlist);


jirka