Re: [PATCH] media: Doc s5p-mfc add missing fields to s5p_mfc_dev structure definition

From: Javier Martinez Canillas
Date: Fri Jul 08 2016 - 13:11:40 EST


Hello Shuah,

On 07/08/2016 10:12 AM, Shuah Khan wrote:
> Add missing documentation for s5p_mfc_dev structure definition.
>
> Signed-off-by: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx>
> ---
> drivers/media/platform/s5p-mfc/s5p_mfc_common.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_common.h b/drivers/media/platform/s5p-mfc/s5p_mfc_common.h
> index 9eb2481..1d06d6a 100644
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_common.h
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_common.h
> @@ -291,7 +291,9 @@ struct s5p_mfc_priv_buf {
> * @warn_start: hardware error code from which warnings start
> * @mfc_ops: ops structure holding HW operation function pointers
> * @mfc_cmds: cmd structure holding HW commands function pointers
> + * @mfc_regs: structure holding MFC registers
> * @fw_ver: loaded firmware sub-version
> + * risc_on: flag indicates RISC is on or off
> *
> */
> struct s5p_mfc_dev {
>

Patch looks good to me.

Reviewed-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>

Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America