Re: [PATCH] qla2xxx: Fix NULL pointer deref in QLA interrupt

[Himanshu Madhani]

On 7/8/16, 12:27 AM, "Thorsten Leemhuis" <regressions@xxxxxxxxxxxxx> wrote:

>Bruno PrÃmont wrote on 30.06.2016 17:00:
>> In qla24xx_process_response_queue() rsp->msix->cpuid may trigger NULL
>> pointer dereference when rsp->msix is NULL:
>> [â]
>> The affected code was introduced by commit cdb898c52d1dfad4b4800b83a58b3fe5d352edde
>> (qla2xxx: Add irq affinity notification).
>> 
>> Only dereference rsp->msix when it has been set so the machine can boot
>> fine. Possibly rsp->msix is unset because:
>> [    3.479679] qla2xxx [0000:00:00.0]-0005: : QLogic Fibre Channel HBA Driver: 8.07.00.33-k.
>> [    3.481839] qla2xxx [0000:13:00.0]-001d: : Found an ISP2432 irq 17 iobase 0xffffc90000038000.
>> [    3.484081] qla2xxx [0000:13:00.0]-0035:0: MSI-X; Unsupported ISP2432 (0x2, 0x3).
>> [    3.485804] qla2xxx [0000:13:00.0]-0037:0: Falling back-to MSI mode -258.
>> [    3.890145] scsi host0: qla2xxx
>> [    3.891956] qla2xxx [0000:13:00.0]-00fb:0: QLogic QLE2460 - PCI-Express Single Channel 4Gb Fibre Channel HBA.
>> [    3.894207] qla2xxx [0000:13:00.0]-00fc:0: ISP2432: PCIe (2.5GT/s x4) @ 0000:13:00.0 hdma+ host#=0 fw=7.03.00 (9496).
>> [    5.714774] qla2xxx [0000:13:00.0]-500a:0: LOOP UP detected (4 Gbps).
>
>Bruno: Does that mean you actually tested that patch and it fixed the
>problem for you? It looks like it, but there is some confusion about it;
>that's one of the reasons why this patch didn't get any further yet
>afaics, so a quick clarification might help to finally get this fixed
>properly in mainline and stable.
>
>Himanshu: While at it: Can you confirm this patch should get merged to
>mainline? Seems Quinn is on PTO and his out-of-office reply mentioned
>you as one point of contact.

I see this patch has been queued to âfixes" branch on Jamesâs tree. So it would
get merged into mainline kernel.  Hereâs link 

http://git.kernel.org/cgit/linux/kernel/git/jejb/scsi.git/log/?h=fixes

>
>Cheers, your regression tracker for Linux 4.7
> Thorsten
>
>> CC: <stable@xxxxxxxxxxxxxxx>
>> Signed-off-by: Bruno PrÃmont <bonbons@xxxxxxxxxxxxxxxxx>
>> ---
>> diff --git a/drivers/scsi/qla2xxx/qla_isr.c
>> b/drivers/scsi/qla2xxx/qla_isr.c index 5649c20..a92a62d 100644
>> --- a/drivers/scsi/qla2xxx/qla_isr.c
>> +++ b/drivers/scsi/qla2xxx/qla_isr.c
>> @@ -2548,7 +2548,7 @@ void qla24xx_process_response_queue(struct
>> scsi_qla_host *vha, if (!vha->flags.online)
>>  		return;
>>  
>> -	if (rsp->msix->cpuid != smp_processor_id()) {
>> +	if (rsp->msix && rsp->msix->cpuid != smp_processor_id()) {
>>  		/* if kernel does not notify qla of IRQ's CPU change,
>>  		 * then set it here.
>>  		 */
>> 
>> http://news.gmane.org/find-root.php?message_id=20160630170032.6dbaf496%40pluto.restena.lu 
>> http://mid.gmane.org/20160630170032.6dbaf496%40pluto.restena.lu
>>