Re: [v6,2/2] PCI: Rockchip: Add Rockchip PCIe controller support

[Arnd Bergmann]

On Friday, July 8, 2016 9:35:11 AM CEST Guenter Roeck wrote:
> On Wed, Jul 06, 2016 at 03:16:38PM +0800, Shawn Lin wrote:
> > This patch adds Rockchip PCIe controller support found
> > on RK3399 Soc platform.
> > 
> > Signed-off-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>
> > ---
> 
> [ ... ]
> 
> > +     /* Get the I/O and memory ranges from DT */
> > +     resource_list_for_each_entry(win, &res) {
> > +             switch (resource_type(win->res)) {
> > +             case IORESOURCE_IO:
> > +                     io = win->res;
> > +                     io->name = "I/O";
> > +                     io_size = resource_size(io);
> > +                     io_bus_addr = io->start - win->offset;
> > +                     err = pci_remap_iospace(io, io_base);
> 
> This function is not exported. Either it will have to be exported
> (which may be difficult since it is declared as __weak), or the
> driver must only be built into the kernel, or the function can
> not be used.
> 

I think we can simply drop the __weak annotation, there is no other
implementation of this, and I doubt there will ever be. Even if it
was needed, we could do it in a different way.

	Arnd