Re: [PATCH 0/9] mm: Hardened usercopy
From: Andy Lutomirski
Date: Sat Jul 09 2016 - 17:27:52 EST
On Jul 6, 2016 6:25 PM, "Kees Cook" <keescook@xxxxxxxxxxxx> wrote:
>
> Hi,
>
> This is a start of the mainline port of PAX_USERCOPY[1]. After I started
> writing tests (now in lkdtm in -next) for Casey's earlier port[2], I
> kept tweaking things further and further until I ended up with a whole
> new patch series. To that end, I took Rik's feedback and made a number
> of other changes and clean-ups as well.
>
I like the series, but I have one minor nit to pick. The effect of
this series is to harden usercopy, but most of the code is really
about infrastructure to validate that a pointed-to object is valid.
Might it make sense to call the infrastructure part something else?
After all, this could be extended in the future for memcpy or even for
some GCC plugin to check pointers passed to ordinary (non-allocator)
functions.