Re: [PATCH 5/7] bus: vexpress-config: add missing of_node_put after calling of_parse_phandle

From: Liviu Dudau
Date: Mon Jul 11 2016 - 05:02:29 EST


On Fri, Jul 01, 2016 at 05:41:59PM +0800, Peter Chen wrote:
> of_node_put needs to be called when the device node which is got
> from of_parse_phandle has finished using.
>
> Cc: Liviu Dudau <liviu.dudau@xxxxxxx>
> Cc: Sudeep Holla <sudeep.holla@xxxxxxx>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>
> Signed-off-by: Peter Chen <peter.chen@xxxxxxx>

Acked-by: Liviu Dudau <Liviu.Dudau@xxxxxxx>

> ---
> drivers/bus/vexpress-config.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bus/vexpress-config.c b/drivers/bus/vexpress-config.c
> index c3cb76b..9efdf1d 100644
> --- a/drivers/bus/vexpress-config.c
> +++ b/drivers/bus/vexpress-config.c
> @@ -178,6 +178,7 @@ static int vexpress_config_populate(struct device_node *node)
>
> parent = class_find_device(vexpress_config_class, NULL, bridge,
> vexpress_config_node_match);
> + of_node_put(bridge);
> if (WARN_ON(!parent))
> return -ENODEV;
>
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
Â\_(ã)_/Â