Re: [PATCH v2 1/6] iommu: add IOMMU_PRIV attribute

[Robin Murphy]

On 09/07/16 03:09, Mitchel Humpherys wrote:
> Add the IOMMU_PRIV attribute, which is used to indicate privileged
> mappings.
> 
> Signed-off-by: Mitchel Humpherys <mitchelh@xxxxxxxxxxxxxx>
> ---
>  include/linux/iommu.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index 664683aedcce..01c9f2667f2b 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -31,6 +31,7 @@
>  #define IOMMU_CACHE	(1 << 2) /* DMA cache coherency */
>  #define IOMMU_NOEXEC	(1 << 3)
>  #define IOMMU_MMIO	(1 << 4) /* e.g. things like MSI doorbells */
> +#define IOMMU_PRIV	(1 << 5)

I agree on the IOMMU_PRIV name, but can't help thinking it might be
worth a brief comment to make it abundantly clear at a glance that it
isn't "private" or "priority 5" or whatever ;)

Robin.

>  struct iommu_ops;
>  struct iommu_group;
>