Re: [PATCH 1/2] mfd: cros_ec: Add MKBP event support

[Lee Jones]

On Tue, 05 Jul 2016, Olof Johansson wrote:

> On Tue, Jul 5, 2016 at 2:00 PM, Dmitry Torokhov
> <dmitry.torokhov@xxxxxxxxx> wrote:
> > On July 5, 2016 1:55:44 PM PDT, Olof Johansson <olof@xxxxxxxxx> wrote:
> >>On Tue, Jul 5, 2016 at 1:54 PM, Olof Johansson <olof@xxxxxxxxx> wrote:
> >>> On Fri, Jul 1, 2016 at 2:07 AM, Enric Balletbo i Serra
> >>> <enric.balletbo@xxxxxxxxxxxxx> wrote:
> >>>> From: Vic Yang <victoryang@xxxxxxxxxx>
> >>>>
> >>>> Newer revisions of the ChromeOS EC add more events besides the
> >>keyboard
> >>>> ones. So handle interrupts in the MFD driver and let consumers
> >>register
> >>>> for notifications for the events they might care.
> >>>>
> >>>> To keep backward compatibility, if the EC doesn't support MKBP
> >>event, we
> >>>> fall back to the old MKBP key matrix host command.
> >>>>
> >>>> Signed-off-by: Vic Yang <victoryang@xxxxxxxxxx>
> >>>> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@xxxxxxxxxxxxx>
> >>>> Tested-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>
> >>>> Cc: Randall Spangler <rspangler@xxxxxxxxxxxx>
> >>>> Cc: Vincent Palatin <vpalatin@xxxxxxxxxxxx>
> >>>> Cc: Benson Leung <bleung@xxxxxxxxxxxx>
> >>>
> >>> Probably easiest to merge this through the MFD tree due to the
> >>> overlaps, so for that purpose:
> >>>
> >>> Acked-by: Olof Johansson <olof@xxxxxxxxx>
> >>
> >>Argh, I just noticed that the second patch is an input patch, not
> >>another MFD patch. Either way, I'm OK with this going through the
> >>input tree if that's easiest. If so, you should probably wait for an
> >>ack from Lee as well.
> >
> > Hmm, I thought I already acked input portion to go through MFD tree... or am I confusing this with some other patch?
> 
> Oh, then we're all set. That patch didn't thread with this one in my
> mailbox so I didn't see the comment thread on it.
 
Yes, same for me.

> Lee, all yours.

Err, nice, ta!  =;-)

Eric,

Please resubmit this set 'threaded' so I might take proper care of
it.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog