Re: lustre sendmsg stuff
From: Oleg Drokin
Date: Mon Jul 11 2016 - 18:55:29 EST
On Jul 10, 2016, at 9:03 PM, Al Viro wrote:
> On Mon, Jul 11, 2016 at 02:01:13AM +0100, Al Viro wrote:
>> On Sun, Jul 10, 2016 at 07:14:18PM +0100, James Simmons wrote:
>>
>>> [ 111.210818] [<ffffffffa04012bd>] kiblnd_send+0x51d/0x9e0 [ko2iblnd]
>>
>> Mea culpa - in kiblnd_send() this
>> if (payload_kiov)
>> iov_iter_bvec(&from, ITER_BVEC | WRITE,
>> payload_kiov, payload_niov, payload_nob);
>> else
>> iov_iter_kvec(&from, ITER_BVEC | WRITE,
>> payload_iov, payload_niov, payload_nob);
>> should have s/BVEC/KVEC/ in the iov_iter_kvec() arguments. Cut'n'paste
>> braindamage...
>
> PS: That was introduced in the last commit in that pile - "lustre: introduce
> lnet_copy_{k,}iov2iter(), kill lnet_copy_{k,}iov2{k,}iov()".
Is this something you plan to submit to Linus or should I just submit this to
Greg along with other changes?