Re: [PATCH 3/3] Documentation: mmc: add description for new no-sd* and no-mmc

[Shawn Lin]

Hi Rob,

On 2016/7/11 21:57, Rob Herring WROTE:
> On Fri, Jul 01, 2016 at 03:45:30PM +0800, Shawn Lin wrote:
> > This patch adds description for no-sd, no-sdio, no-mmc. We
> > expect the specific boards adds these in DT to improve
> > the initialization. For instance, for a soldered eMMC slot,
> > we could skip sending SDIO and SD commands to probe its card
> > types as it's always should be the type fo MMC card.
> >
> > Signed-off-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>
> > ---
> >
> >  Documentation/devicetree/bindings/mmc/mmc.txt | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt b/Documentation/devicetree/bindings/mmc/mmc.txt
> > index ecc007a..b2046c6 100644
> > --- a/Documentation/devicetree/bindings/mmc/mmc.txt
> > +++ b/Documentation/devicetree/bindings/mmc/mmc.txt
> > @@ -49,6 +49,9 @@ Optional properties:
> >  - mmc-hs400-enhanced-strobe: eMMC HS400 enhanced strobe mode is supported
> >  - dsr: Value the card's (optional) Driver Stage Register (DSR) should be
> >    programmed with. Valid range: [0 .. 0xffff].
> > +- no-sdio: skip sending sdio cmd during initialization
> > +- no-sd: skip sending sd cmd during initialization
> > +- no-mmc: skip sending mmc cmd during initialization
>
> I still have issue with the description for these properties and the
> commit msg. They are fine if described as controller limitations as Ulf
> described. If folks want to (ab)use the properties for just skipping
> init, then that's their problem.

Sounds like it's okay for you if I amend the commit msg and drscription
to emphasize that these properties are intent to describe the
limitations of controllers rather than to skip init.

I will fix them.

Thanks.

> Rob


--
Best Regards
Shawn Lin