Re: [PATCH 4/7] gpu: drm: sti_hqvdp: add missing of_node_put after calling of_parse_phandle

[Benjamin Gaignard]

Acked-by: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxx>

2016-07-05 4:04 GMT+02:00 Peter Chen <peter.chen@xxxxxxx>:
> of_node_put needs to be called when the device node which is got
> from of_parse_phandle has finished using.
>
> Cc: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxx>
> Cc: Vincent Abriou <vincent.abriou@xxxxxx>
> Signed-off-by: Peter Chen <peter.chen@xxxxxxx>
> ---
>  drivers/gpu/drm/sti/sti_hqvdp.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b/drivers/gpu/drm/sti/sti_hqvdp.c
> index 1edec29..4f052fa 100644
> --- a/drivers/gpu/drm/sti/sti_hqvdp.c
> +++ b/drivers/gpu/drm/sti/sti_hqvdp.c
> @@ -1346,6 +1346,7 @@ static int sti_hqvdp_probe(struct platform_device *pdev)
>         vtg_np = of_parse_phandle(pdev->dev.of_node, "st,vtg", 0);
>         if (vtg_np)
>                 hqvdp->vtg = of_vtg_find(vtg_np);
> +       of_node_put(vtg_np);
>
>         platform_set_drvdata(pdev, hqvdp);
>
> --
> 1.9.1
>



-- 
Benjamin Gaignard

Graphic Working Group

Linaro.org â Open source software for ARM SoCs

Follow Linaro: Facebook | Twitter | Blog