Re: [PATCH] media: s5p-mfc Fix misspelled error message and checkpatch errors

[Shuah Khan]

On 07/12/2016 08:06 AM, Joe Perches wrote:
> On Mon, 2016-07-11 at 16:39 -0600, Shuah Khan wrote:
>> Fix misspelled error message and existing checkpatch errors in the
>> error message conditional.
> []
>> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
> []
>> @@ -775,11 +775,11 @@ static int vidioc_g_crop(struct file *file, void *priv,
>>  	u32 left, right, top, bottom;
>>  
>>  	if (ctx->state != MFCINST_HEAD_PARSED &&
>> -	ctx->state != MFCINST_RUNNING && ctx->state != MFCINST_FINISHING
>> -					&& ctx->state != MFCINST_FINISHED) {
>> -			mfc_err("Cannont set crop\n");
>> -			return -EINVAL;
>> -		}
>> +	    ctx->state != MFCINST_RUNNING && ctx->state != MFCINST_FINISHING
>> +	    && ctx->state != MFCINST_FINISHED) {
>> +		mfc_err("Can not get crop information\n");
>> +		return -EINVAL;
>> +	}
> 
> is it a set or a get?

vidioc_g_crop is a get routine.

> 
> It'd be nicer for humans to read if the alignment was consistent

Are you okay with this alignment change or would you like it
changed? checkpatch stopped complaining with the code as follows:

> 
> 	if (ctx->state != MFCINST_HEAD_PARSED &&
> 	    ctx->state != MFCINST_RUNNING &&
> 	    ctx->state != MFCINST_FINISHING &&
> 	    ctx->state != MFCINST_FINISHED) {
> 		mfc_err("Can not get crop information\n");
> 		return -EINVAL;
> 	}
> 
> 

thanks,
-- Shuah