Re: [PATCH 44/93] clocksource/drivers/time-armada-370-xp: Convert init function to return error

[Thomas Gleixner]

On Tue, 12 Jul 2016, Anna-Maria Gleixner wrote:
> On Thu, 7 Jul 2016, Daniel Lezcano wrote:
> > +	res = armada_370_xp_timer_setup(this_cpu_ptr(armada_370_xp_evt));
> > +	if (!res) {
> 
> I think the "!" is a mistake, because armada_370_xp_timer_setup()
> returns zero. See delta patch fixing this below.

Yes it is wrong.

Care to send a proper patch with a proper changelog?
 
Thanks,

	tglx

> 8<-------------------
> --- a/drivers/clocksource/time-armada-370-xp.c
> +++ b/drivers/clocksource/time-armada-370-xp.c
> @@ -342,7 +342,7 @@ static int __init armada_370_xp_timer_co
>  	}
>  
>  	res = armada_370_xp_timer_setup(this_cpu_ptr(armada_370_xp_evt));
> -	if (!res) {
> +	if (res) {
>  		pr_err("Failed to setup timer");
>  		return res;
>  	}
>