Re: [PATCH 20/34] mm: move vmscan writes and file write accounting to the node

From: Johannes Weiner
Date: Tue Jul 12 2016 - 11:16:07 EST


On Fri, Jul 08, 2016 at 10:34:56AM +0100, Mel Gorman wrote:
> As reclaim is now node-based, it follows that page write activity due to
> page reclaim should also be accounted for on the node. For consistency,
> also account page writes and page dirtying on a per-node basis.
>
> After this patch, there are a few remaining zone counters that may appear
> strange but are fine. NUMA stats are still per-zone as this is a
> user-space interface that tools consume. NR_MLOCK, NR_SLAB_*,
> NR_PAGETABLE, NR_KERNEL_STACK and NR_BOUNCE are all allocations that
> potentially pin low memory and cannot trivially be reclaimed on demand.
> This information is still useful for debugging a page allocation failure
> warning.
>
> Signed-off-by: Mel Gorman <mgorman@xxxxxxxxxxxxxxxxxxx>
> Acked-by: Vlastimil Babka <vbabka@xxxxxxx>
> Acked-by: Michal Hocko <mhocko@xxxxxxxx>

More conversion... ;) FWIW, I didn't spot anything problematic. And
agreed with leaving unmovable stuff counters on a per-zone basis.

Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>