Re: [PATCH] sched/fair: Fix the misuse of cfs_rq in sync_throttle()

From: Peter Zijlstra
Date: Tue Jul 12 2016 - 11:26:46 EST


On Sat, Jul 09, 2016 at 03:54:22PM +0800, Xunlei Pang wrote:
> +++ b/kernel/sched/fair.c
> @@ -4269,7 +4269,7 @@ static void sync_throttle(struct task_group *tg, int cpu)
> pcfs_rq = tg->parent->cfs_rq[cpu];
>
> cfs_rq->throttle_count = pcfs_rq->throttle_count;
> - pcfs_rq->throttled_clock_task = rq_clock_task(cpu_rq(cpu));
> + cfs_rq->throttled_clock_task = rq_clock_task(cpu_rq(cpu));

Ah indeed, thanks!

> }
>
> /* conditionally throttle active cfs_rq's from put_prev_entity() */
> --
> 1.8.3.1
>