Re: [PATCH v2] relay: Add global mode support for buffer-only channels
From: Andrew Morton
Date: Tue Jul 12 2016 - 15:51:41 EST
On Tue, 12 Jul 2016 18:54:49 +0530 "Goel, Akash" <akash.goel@xxxxxxxxx> wrote:
> On 7/12/2016 6:31 PM, Chris Wilson wrote:
> > On Tue, Jul 12, 2016 at 06:20:06PM +0530, Goel, Akash wrote:
> >> Thanks much, will update the documentation as well as the changelog
> >> as per the above.
> >> But an export of symbol relay_late_setup_files() is still needed, just
> >> like relay_open() is exported, in order to make it accessible to
> >> modules like i915 ?
> > Yes, we need the companion function in i915.ko. That needs to be
> > explained in the patch notes to justify adding the EXPORT_SYMBOL.
> > Otherwise without that context, it looks unnecessary as Andrew objected
> > to.
> Won't your suggested updates to Documentation & changelog suffice ?.
> relay_late_setup_files() is to be used in conjunction with
> relay_open(), hence need to be exported.
> Do I also need to provide the corresponding i915 patch, which has a
> call to relay_late_setup_files() ?
No, as long as i915 people promise to use the export, a note in the
changelog is sufficient.