Re: [PATCH v5 18/32] signal: Consolidate {TS,TLF}_RESTORE_SIGMASK code

From: Andy Lutomirski
Date: Tue Jul 12 2016 - 19:01:57 EST


On Tue, Jul 12, 2016 at 4:57 AM, Brian Gerst <brgerst@xxxxxxxxx> wrote:
> On Mon, Jul 11, 2016 at 4:53 PM, Andy Lutomirski <luto@xxxxxxxxxx> wrote:
>> In general, there's no need for the "restore sigmask" flag to live in
>> ti->flags. alpha, ia64, microblaze, powerpc, sh, sparc (64-bit only),
>> tile, and x86 use essentially identical alternative implementations,
>> placing the flag in ti->status.
>>
>> Replace those optimized implementations with an equally good common
>> implementation that stores it in a bitfield in struct task_struct
>> and drop the custom implementations.
>>
>> Additional architectures can opt in by removing their
>> TIF_RESTORE_SIGMASK defines.
>
> There is a small typo in the subject, should be "signal: Consolidate
> {TS,TIF}_RESTORE_SIGMASK code"

I really did mean "TLF" -- it's a powerpc-ism. This patch doesn't
affect TIF_RESTORE_SIGMASK on architectures that have that flag,
although it makes it much easier for them to get rid of it.

--Andy