Re: [PATCH v4] [media] pci: Add tw5864 driver - fixed few style nits, going to resubmit soon

[Hans Verkuil]

On 07/13/2016 04:05 AM, Andrey Utkin wrote:
> Found and fixed few very minor coding style nits, will resubmit in few days,
> now still waiting for comments to v4.

Can you resubmit now? I plan to review it on Friday or Monday, and I'd rather
review the latest version.

Regards,

	Hans

> 
> https://github.com/bluecherrydvr/linux/commits/tw5864
> 
> commit 31f7c98a144cb3fb8a94662f002d9b6142d1f390
> Author: Andrey Utkin <andrey.utkin@xxxxxxxxxxxxxxxxxxx>
> Date:   Wed Jul 13 05:00:28 2016 +0300
> 
>     Fix checkpatch --strict issue
>     
>      CHECK: Alignment should match open parenthesis
>      #3599: FILE: drivers/media/pci/tw5864/tw5864-video.c:539:
>      +static int tw5864_fmt_vid_cap(struct file *file, void *priv,
>      +                               struct v4l2_format *f)
> 
> commit 11a09a1048af597ecf374507b08c809eed91b86d
> Author: Andrey Utkin <andrey.utkin@xxxxxxxxxxxxxxxxxxx>
> Date:   Wed Jul 13 04:59:34 2016 +0300
> 
>     Fix checkpatch --strict issue
>     
>      CHECK: Please don't use multiple blank lines
>      #3244: FILE: drivers/media/pci/tw5864/tw5864-video.c:184:
> 
> commit 861b2ba8593db7abe89291a4ba85976519783f4a
> Author: Andrey Utkin <andrey.utkin@xxxxxxxxxxxxxxxxxxx>
> Date:   Wed Jul 13 04:58:37 2016 +0300
> 
>     Fix checkpatch --strict issue
>     
>      CHECK: No space is necessary after a cast
>      #3053: FILE: drivers/media/pci/tw5864/tw5864-util.c:36:
>      +       return (u8) tw_readl(TW5864_IND_DATA);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>