Re: [PATCH] userspace API definitions for auto-focus coil
From: Pavel Machek
Date: Wed Jul 13 2016 - 03:26:47 EST
On Tue 2016-07-12 20:32:01, Mauro Carvalho Chehab wrote:
> Em Sat, 18 Jun 2016 17:38:46 +0200
> Pavel Machek <pavel@xxxxxx> escreveu:
> > Hi!
> > > > Not V4L2_CID_USER_AD5820...?
> > >
> > > The rest of the controls have no USER as part of the macro name, so I
> > > wouldn't use it here either.
> > Ok.
> > > > Ok, separate header file for 2 lines seemed like a bit of overkill,
> > > > but why not.
> > >
> > > That follows an existing pattern of how controls have been implemented in
> > > other drivers.
> > Ok.
> > > Could you merge this with the driver patch? I've dropped that from my ad5820
> > > branch as it does not compile.
> > Yes, merged patch should be in your inbox now.
> The V4L2 core changes should be on a separate patch. Btw, you'll also
> need to patch documentation to reflect such changes. We're right now
> moving from DocBook to ReST markup language. The patches for it are
> right now on a separate topic branch (docs-next), to be merged for
> Kernel 4.8 on the next merge window.
What about: I drop all the functionality but FOCUS_ABSOLUTE, which is
core functionality, anyway, and does not need core changes. When V4L2
core stabilizes, it can be reintroduced.
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html